Skip to content

[WIP] DCOM-118 - DCOM-121 #17

Closed
wants to merge 3 commits into from

2 participants

@Ocramius
Doctrine member
Ocramius commented Dec 3, 2013

This PR is a port of the hotfix for DCOM-121 at doctrine/common#198

@Ocramius Ocramius referenced this pull request in doctrine/common Dec 3, 2013
Closed

[DCOM-118] fix for issue #195 #198

@schmittjoh
Doctrine member

This breaks multi-line strings if I'm not mistaken?

@Ocramius
Doctrine member
Ocramius commented Dec 3, 2013

@schmittjoh I think there's a comment about that in the PR. I'll add a test to verify that so we can discuss it :-)

@Ocramius
Doctrine member
Ocramius commented Dec 3, 2013

I've created a gist for the brave ones that believe they know regex-fu: https://gist.github.com/Ocramius/b147fc172a96d73df4be

@Ocramius
Doctrine member

Handled in #28

@Ocramius Ocramius closed this Mar 25, 2014
@Ocramius Ocramius deleted the Ocramius:hotfix/DCOM-118 branch Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.