Merged
Conversation
malarzm
previously approved these changes
Oct 26, 2022
Member
malarzm
left a comment
malarzm
left a comment
There was a problem hiding this comment.
Do we want to advettise the fact in docs?
malarzm
reviewed
Oct 26, 2022
tests/Doctrine/Tests/Common/Annotations/AnnotationReaderTest.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
test/enum
branch
3 times, most recently
from
483be45 to
0b7c935
Compare
Member
Author
|
I don't know if it's worth mentioning enums in the docs. 🤷🏻♂️ |
stof
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By coincidence, we already support enums in annotations. Let's add some tests to make sure it stays that way.