Add sniff to ensure spaces around binary operators #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
May 22, 2019
| @@ -11,7 +11,7 @@ | |||
| } elseif (! $test === 0) { | |||
| echo 0; | |||
| } else { | |||
| echo -1; | |||
| echo - 1; | |||
There was a problem hiding this comment.
This looks like a bug. It's a unary minus, should not be affected by the rule.
There was a problem hiding this comment.
Please see squizlabs/PHP_CodeSniffer#429.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| declare(strict_types=1); | |||
|
|
|||
| echo -1; | |||
| echo - 1; | |||
There was a problem hiding this comment.
This looks like a bug. It's a unary minus, should not be affected by the rule.
|
An update on this one: we're still waiting for squizlabs/PHP_CodeSniffer#2456 which will fix the issue raised by #126 (comment). The solutions presented in squizlabs/PHP_CodeSniffer#2425, such as |
|
Deferred to |
|
This was solved via #148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more generic sniff to the problem that we're trying to solve with #123.