Support for 'IsNotNull' in ExpressionBuilder #11

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

Allows to filter Collections with a 'IsNotNull'-Criteria

@pmattmann pmattmann Support for 'IsNotNull' in ExpressionBuilder
Allows to filter Collections with a 'IsNotNull'-Criteria
61ffd30

pmattmann referenced this pull request in doctrine/doctrine2 May 20, 2013

Closed

Implementation for 'IsNot'-Comparison #675

@guilhermeblanco guilhermeblanco commented on an outdated diff May 22, 2013

.../Common/Collections/Expr/ClosureExpressionVisitor.php
@@ -113,6 +113,7 @@ public function walkComparison(Comparison $comparison)
};
case Comparison::NEQ:
+ case Comparison::ISNOT:
@guilhermeblanco

guilhermeblanco May 22, 2013

Owner

Please switch to IS_NOT.

Member

asm89 commented May 26, 2013

We deprecated IS because it probably shouldn't be there in the first place (it's only to do the SQL IS NOT NULL thing). Instead we made ->eq('field', null); and ->neq('field', null); working in the ORM.

asm89 closed this May 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment