DCOM-128: RedisCache uses IGBINARY which is not always available #427

Closed
doctrinebot opened this Issue Oct 20, 2012 · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user sandermarechal:

The RedisCache uses Redis::SERIALIZER_IGBINARY. See https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Cache/RedisCache.php line 47.

The problem is that the php Redis extension can be compiled without IGBINARY support. In that case, this code causes a fatal error because the constant does not exist.

The DotDeb package of php5-redis (often used on Debian systems) for example comes compiled without IGBINARY support.

The code should probably check if the constant exists. If not, the default to Redis::SERIALIZER_PHP

@doctrinebot

Comment created by peterjmit:

This appears like it will be fixed when 2.4 is released https://github.com/doctrine/cache/blob/master/lib/Doctrine/Common/Cache/RedisCache.php#L128

@doctrinebot

Comment created by @ocramius:

Already fixed in master

@doctrinebot

Issue was closed with resolution "Fixed"

@Ocramius Ocramius was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment