DCOM-223: [GH-308] fix the optimize regex and adapt the tests to actually test classAnnotat... #530

doctrinebot opened this Issue Dec 12, 2013 · 3 comments

2 participants


Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of dawehner:

Url: #308


There has been several problems

  • Even we enabled classAnnotationOptimized we expected a different behavior: You cannot parse properties any longer (fixed that by expecting an exception). Therefore moved the test data into a provider so you can check the exception on each of them.
  • Once done I realized that DeeperNamespaceParent had the wrong className
  • Additional I added a test to check that the regex matched.

Comment created by @doctrinebot:

A related Github Pull-Request [GH-308] was closed:


Comment created by @ocramius:

Merged: a45d110


Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.5.0 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment