DCOM-6: Non existant namespace alias throws a PHP Notice #660

Closed
doctrinebot opened this Issue May 27, 2010 · 6 comments

2 participants

@doctrinebot

Jira issue originally created by user merk:

@nonalias:Annot results in a php notice.

@doctrinebot

Comment created by @guilhermeblanco:

In commit: http://github.com/doctrine/common/commit/ad49a676269af368563bd9a848c904b81a825622

I fixed this issue.
The validation on unexistent classes cannot be done correctly, otherwise it'd conflict with phpDoc tags.

@doctrinebot

Comment created by merk:

What will your change do if there are multiple implementations of the Reader working on entities that dont have common namespaces, but still use namespaces?

Would it not make more sense to skip something that the Reader doesnt understand, rather than throwing an error?

(For example, Symfony2's validator system might have namespaced validators, which would then cause the 'Doctrine' reader to throw an exception)

@doctrinebot

Comment created by @guilhermeblanco:

Yes, you're right...

I think we'll have to silently bypass unknown aliases... this makes debug harder, but we don't have any other option. =(

Reopening it

@doctrinebot

Comment created by @beberlei:

Fixed to skip the unknown alias annotation.

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label Dec 6, 2015
@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0.0-RC1 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment