Skip to content

Loading…

DCOM-86: k-fish #687

Closed
doctrinebot opened this Issue · 2 comments

1 participant

@doctrinebot

Jira issue originally created by user k-fish:

When parsing a class the DocParser uses class_exists() to check for annotation classes (this triggers autoloading) - only afterwards the annotation is ignored if it should be ignored.

At least for simple unqualified names the check against the ignored annotations could be done earlier. This already goes a long way:

----- DocParser.php, at about line 555 -----
// only process names which are not fully qualified, yet
// fully qualified names must start with a \
$originalName = $name;
if ('\' !== $name[0]) {
// check early and return before further inspections
if (isset($this->ignoredAnnotationNames[$name])) {
return FALSE;
}
$alias = (false === $pos = strpos($name, '\'))? $name : substr($name, 0, $pos);

----- DocParser.php, at about line 555 -----

@doctrinebot

Comment created by @FabioBatSilva:

Other explanations : #90 (comment)

@doctrinebot

Issue was closed with resolution "Won't Fix"

@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.