DCOM-96: Extract a common ProxyFactory #697

Closed
doctrinebot opened this Issue Feb 12, 2012 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user stof:

Currently, each Doctrine project implements its own ProxyFactory. But the most part of the logic is simply copy-pasted from the ORM implementation (or from an older version of the ORM implementation). Extracting the common code would be a good idea to avoid having to maintain 4 places (or even more) containing the same logic

@doctrinebot

Comment created by @ocramius:

I have a working implementation of public properties lazy loading at Ocramius/doctrine2@master...[DCOM-96](http://www.doctrine-project.org/jira/browse/DCOM-96)-restarted

I am still trying to figure out performance issues, since this PR adds 5% overhead on top of Hydrators/Persisters/UnitOfWork, since it turned out that


actually triggers PHP's magic **get method.
I've worked this around by assuming nulls when values are not set, but this adds some conditionals that obviously slow down all the extraction of values process.

@doctrinebot

Issue was closed with resolution "Fixed"

@Ocramius Ocramius was assigned by doctrinebot Dec 7, 2015
@doctrinebot doctrinebot added this to the 2.4 milestone Dec 7, 2015
@doctrinebot doctrinebot closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment