Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Doctrine/Common/ClassLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,12 @@ public static function classExists($className)
} else if (is_string($loader) && $loader($className)) { // "MyClass::loadClass"
return true;
}
if (class_exists($className, false) || interface_exists($className, false)) {
return true;
}
}

return class_exists($className, false) || interface_exists($className, false);
return false;
}

/**
Expand Down
19 changes: 19 additions & 0 deletions tests/Doctrine/Tests/Common/ClassLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,26 @@ public function testClassExists()
$this->assertTrue(ClassLoader::classExists('ClassLoaderTest\ClassD'));
spl_autoload_unregister($badLoader);
}

public function testClassExistsWithMultipleNonReturningAutoloaders()
{
$this->assertFalse(ClassLoader::classExists('ClassLoaderTest\ClassE'));
$nonReturnLoader = function($className) {
if (class_exists($className, false)) {
\PHPUnit_Framework_Assert::fail('Class load called twice for same class.');
}
require __DIR__ . '/ClassLoaderTest/ClassE.php';
};
$nonReturnLoader2 = clone $nonReturnLoader;

spl_autoload_register($nonReturnLoader);
spl_autoload_register($nonReturnLoader2);

$this->assertTrue(ClassLoader::classExists('ClassLoaderTest\ClassE'));
spl_autoload_unregister($nonReturnLoader);
spl_autoload_unregister($nonReturnLoader2);
}

public function testGetClassLoader()
{
$cl = new ClassLoader('ClassLoaderTest', __DIR__);
Expand Down
5 changes: 5 additions & 0 deletions tests/Doctrine/Tests/Common/ClassLoaderTest/ClassE.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?php

namespace ClassLoaderTest;

class ClassE {}