[WIP] [Cache] Move cache ID namespacing to CacheNamespace class#214
Closed
CHH wants to merge 7 commits into
Closed
[WIP] [Cache] Move cache ID namespacing to CacheNamespace class#214CHH wants to merge 7 commits into
CHH wants to merge 7 commits into
Conversation
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
Author
|
This is a pull request to add feature #207 |
Member
|
@beberlei think this is good enough to be used also internally in the https://github.com/doctrine/common/blob/8b403cde97eaede30bd79acab4f18895fd5bdf27/lib/Doctrine/Common/Cache/CacheProvider.php ? |
Member
There was a problem hiding this comment.
constant should be declared before properties
Author
|
I'm closing the PR here and make another one for the new doctrine/cache repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.