hotfix cache #218

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

jakoch commented Nov 16, 2012

a) replaced silence operator by is_file() check.
If there is a lock or permission problem while unlinking a file, the error should pop up.
b) replaced little typo in constant name (availiable => available)

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DCOM-137

@schmittjoh schmittjoh commented on the diff Nov 16, 2012

lib/Doctrine/Common/Cache/Cache.php
@@ -38,8 +38,8 @@
const STATS_HITS = 'hits';
const STATS_MISSES = 'misses';
const STATS_UPTIME = 'uptime';
- const STATS_MEMORY_USAGE = 'memory_usage';
- const STATS_MEMORY_AVAILIABLE = 'memory_available';
+ const STATS_MEMORY_USAGE = 'memory_usage';
+ const STATS_MEMORY_AVAILABLE = 'memory_available';
@schmittjoh

schmittjoh Nov 16, 2012

Member

Can you keep the old constant as well for BC?

Owner

beberlei commented Nov 16, 2012

Can you make two PRs out of this? It fixes two completly different things.

jakoch commented Nov 16, 2012

Sure - splitted the PR into two new PRs.
#219
#220
Closing this one.

jakoch closed this Nov 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment