Skip to content
This repository

Fix for DCOM-106 #223

Merged
merged 1 commit into from over 1 year ago

3 participants

nemekzg doctrinebot Johannes
nemekzg

Both fixme and TODO become ignored.

doctrinebot
Collaborator

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DCOM-143

Johannes schmittjoh merged commit 3fd7343 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 20, 2012
nemekzg nemekzg Fix for DCOM-106 cc7b613
This page is out of date. Refresh to see the latest.
4 lib/Doctrine/Common/Annotations/AnnotationReader.php
@@ -60,7 +60,7 @@ class AnnotationReader implements Reader
60 60 'subpackage'=> true, 'name'=> true, 'global'=> true, 'param'=> true,
61 61 'return'=> true, 'staticvar'=> true, 'category'=> true, 'staticVar'=> true,
62 62 'static'=> true, 'var'=> true, 'throws'=> true, 'inheritdoc'=> true,
63   - 'inheritDoc'=> true, 'license'=> true, 'todo'=> true,
  63 + 'inheritDoc'=> true, 'license'=> true, 'todo'=> true, 'TODO'=> true,
64 64 'deprec'=> true, 'property' => true, 'method' => true,
65 65 'abstract'=> true, 'exception'=> true, 'magic' => true, 'api' => true,
66 66 'final'=> true, 'filesource'=> true, 'throw' => true, 'uses' => true,
@@ -69,7 +69,7 @@ class AnnotationReader implements Reader
69 69 'Required' => true, 'Attribute' => true, 'Attributes' => true,
70 70 'Target' => true, 'SuppressWarnings' => true,
71 71 'ingroup' => true, 'code' => true, 'endcode' => true,
72   - 'package_version' => true,
  72 + 'package_version' => true, 'fixme' => true
73 73 );
74 74
75 75 /**
23 tests/Doctrine/Tests/Common/Annotations/AbstractReaderTest.php
@@ -377,6 +377,16 @@ public function testAnnotationEnumeratorException()
377 377 }
378 378
379 379 /**
  380 + * @group DCOM-106
  381 + */
  382 + public function testIgnoreFixMeAndUpperCaseToDo()
  383 + {
  384 + $reader = $this->getReader();
  385 + $ref = new \ReflectionClass('Doctrine\Tests\Common\Annotations\DCOM106');
  386 + $reader->getClassAnnotations($ref);
  387 + }
  388 +
  389 + /**
380 390 * @return AnnotationReader
381 391 */
382 392 abstract protected function getReader();
@@ -545,6 +555,16 @@ class DummyClassWithEmail
545 555
546 556 }
547 557
  558 +
  559 +/**
  560 + * @fixme public
  561 + * @TODO
  562 + */
  563 +class DCOM106
  564 +{
  565 +
  566 +}
  567 +
548 568 namespace Doctrine\Tests\Common\Annotations\Foo;
549 569
550 570 /** @Annotation */
@@ -559,5 +579,4 @@ class Name extends \Doctrine\Common\Annotations\Annotation
559 579 class Name extends \Doctrine\Common\Annotations\Annotation
560 580 {
561 581 public $name;
562   -}
563   -
  582 +}

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.