[Cache/CouchbaseCache] Return false instead of null for compat. #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset fixes and verifies that instead of null, false is returned from the fetch method. This fixes a bug which causes CouchbaseCache not to work in combination with the ORM library. Test added.
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
Member
There was a problem hiding this comment.
opening { should be on the next line
This changeset makes sure that all supported caches return false and not null when a key is not found. This ensures compatibility with the ORM layer.
Contributor
Author
|
Okay, this also refactors the method one level up the tree so that it will be used for all caching adapters. I think this is necessary in order to make sure we don't break compatibility to the ORM layer which expects false and not null when no doc is found on fetch. If possible, please merge since the CouchbaseCache doesn't work in combination with the ORM layer otherwise. |
stof
added a commit
that referenced
this pull request
Jan 7, 2013
[Cache/CouchbaseCache] Return false instead of null for compat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes and verifies that instead of null, false is returned
from the fetch method. This fixes a bug which causes CouchbaseCache not
to work in combination with the ORM library. Test added.