Undefined variable fix #246

Merged
merged 1 commit into from Jan 26, 2013

Conversation

Projects
None yet
5 participants
Contributor

BenMorel commented Jan 25, 2013

This is a separate PR as suggested in #245, to fix an undefined variable.
Please review the change as I'm not 100% sure what was the intended behaviour.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DCOM-166

Owner

Ocramius commented Jan 25, 2013

Should be rebased on master once #245 is merged

Member

stof commented Jan 25, 2013

@BenMorel could you rewrite your branch to base it on doctrine master instead of your own master branch (used for the other PR) ? This way, the bugfix does not need to wait until the other PR is merged

Contributor

BenMorel commented Jan 25, 2013

Yes, I just realized my mistake. I'll do that right now!

Owner

beberlei commented Jan 26, 2013

@BenMorel can you add a regression test?

Contributor

BenMorel commented Jan 26, 2013

I added a simple test that triggers an Undefined variable: className before the fix.
Again, I'm not sure what was the intended behaviour of this class, so it does not test the actual functionality!

stof added a commit that referenced this pull request Jan 26, 2013

@stof stof merged commit 0cd52ed into doctrine:master Jan 26, 2013

1 check passed

default The Travis build passed
Details

@BenMorel BenMorel deleted the BenMorel:varfix branch Jan 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment