New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCOM-96] Refactor ProxyGenerator, introduce AbstractProxyFactory #247
Conversation
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
||
foreach ($placeholderMatches as $placeholder => $name) { | ||
$placeholders[$placeholder] = isset($this->placeholders[$name]) | ||
? $this->placeholders[$name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget that I need to have a closure here :\
This still needs tests |
}, $placeholders); | ||
|
||
$fileName = $fileName ?: $this->getProxyFileName($class->getName()); | ||
$proxyCode = strtr($this->proxyClassTemplate, $placeholders); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be if
Code is final now. @Ocramius Can you give your opinion? I can merge afterwards. |
$generated = 0; | ||
|
||
foreach ($classes as $class) { | ||
/* @var $class \Doctrine\ORM\Mapping\ClassMetadataInfo */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. It should be the common interface here (and btw, the param phpdoc should be enough)
…stractProxyFactory.
private $definitions = array(); | ||
|
||
/** | ||
* @param ProxyGenerator $proxyGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in sync with parameters. Also, as guilherme said, let's use FQCN
[DCOM-96] Refactor ProxyGenerator, introduce AbstractProxyFactory
This PR does two things: