Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/doctrine/common#247 fixes #248

Merged

Conversation

Ocramius
Copy link
Member

Includes fixes suggested for #247 (plus a weird fix on a failure with array_map on PHP <5.4)

@doctrinebot
Copy link

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DCOM-167

@doctrinebot
Copy link

Oh btw, I just (automatically) realized that you are not creating this pull request against the master branch.

Unless there are good reasons for this, i would suggest to close and rebase the Pull Request against master and then create it again. Sorry!


$proxyFactory = $this->getMock(
$metadataFactory = $this->getMock('Doctrine\Common\Persistence\Mapping\ClassMetadataFactory');
$proxyFactory = $this->getMock(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use getMockForAbstractClass which automatically set the mocked methods (all abstract ones)

beberlei added a commit that referenced this pull request Jan 26, 2013
@beberlei beberlei merged commit 9c9c3c1 into doctrine:ProxyFactory Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants