Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding export attributes #250

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Owner

Ocramius commented Jan 27, 2013

No description provided.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DCOM-170

marijn commented Feb 6, 2013

Please don't remove the tests when exporting.

Owner

Ocramius commented Feb 6, 2013

@marijn it's an export, it's meant to exclude anything not needed in a production env. If you want to test in production, run the installer with --prefer-source and then run the suite

marijn commented Feb 6, 2013

Yeah. I think saving those few bytes on bandwidth is really not worth it. It seems to me the tests are an important part of the documentation, not having them along with the code just feels wrong to me. Installing all my dependencies with --prefer-source is really slow on any medium sized project and above...

On Feb 7, 2013, at 12:38 AM, Marco Pivetta wrote:

@marijn it's an export, it's meant to exclude anything not needed in a production env. If you want to test in production, run the installer with --prefer-source and then run the suite


Reply to this email directly or view it on GitHub.

Owner

Ocramius commented Feb 6, 2013

@marijn since you just said that saving a few bytes on bandwidth is not worth it, I'd say to use --prefer-source in your case and solve it that way ;)

Yes, these are two extremes, but you don't need docs in production code either AFAIK

Member

schmittjoh commented Feb 7, 2013

I didn't really follow this, but symfony reverted a similar change and now
includes tests in the exported archives.

After all, the size increase shouldn't be noticeable, and compared to
prefer-source (where the entire history needs to be cloned), it is
still significantly faster (even with tests). So, might be worth
considering to make a similar change as well.

On Thu, Feb 7, 2013 at 12:43 AM, Marco Pivetta notifications@github.comwrote:

@marijn https://github.com/marijn since you just said that saving a few
bytes on bandwidth is now worth it, I'd say to use --prefer-source in
your case and solve it that way ;)

Yes, these are two extremes, but you don't need docs in production code
either AFAIK


Reply to this email directly or view it on GitHubhttps://github.com/doctrine/common/pull/250#issuecomment-13212543.

Owner

Ocramius commented Apr 16, 2013

Closing - no real need to push this further if there's no interest (only one more issue to handle)

@Ocramius Ocramius closed this Apr 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment