graceful classloader #277

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@Tim-Erwin

Right now if the Doctrine class loader is asked to load a class that it is actually not responsible for (because my class loader is later in the list) it fails with a fatal error. This patch only requires a file if it exists. Other class loaders in the list can still try to load the class.

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jun 4, 2013

Member

While the approach is actually correct, the doctrine class loader was never meant to be failing gracefully. You should instead upgrade to composer autoloading if you want to switch to 2.4, since we actually wanted to deprecated this class.

Member

Ocramius commented Jun 4, 2013

While the approach is actually correct, the doctrine class loader was never meant to be failing gracefully. You should instead upgrade to composer autoloading if you want to switch to 2.4, since we actually wanted to deprecated this class.

@Tim-Erwin

This comment has been minimized.

Show comment Hide comment
@Tim-Erwin

Tim-Erwin Jun 4, 2013

Ok, thanks for the info.

Ok, thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment