[DCOM-194] Fixed proxying magic getter with reference #278

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Member

Majkl578 commented Jun 6, 2013

This is a proposal for a fix for DCOM-194 (and GH issue #276). This issue is important for us to be solved before 2.4.0 is out, since the base object class of Nette Framework, Nette\Object, uses this behavior, see https://github.com/nette/nette/blob/04e4e4b3ee36551fe99e63f91d9a839f7edc72ee/Nette/common/Object.php#L124-133.

(By the way, your Travis environment seems to be broken.)

👍

Owner

beberlei commented Jun 6, 2013

@Ocramius ping

+ * @param $name
+ *
+ * @return string
+ * @throws \BadMethodCallException
@Majkl578

Majkl578 Jun 6, 2013

Member

oops, this shouldn't be here, will fix

Owner

Ocramius commented Jun 6, 2013

@ beberlei can review/merge once I am back in DE (monday)
On 6 Jun 2013 23:44, "Benjamin Eberlei" notifications@github.com wrote:

@Ocramius https://github.com/Ocramius ping


Reply to this email directly or view it on GitHubhttps://github.com/doctrine/common/pull/278#issuecomment-19076290
.

@Ocramius Ocramius referenced this pull request Jun 10, 2013

Merged

DCOM-194 #281

Owner

Ocramius commented Jun 10, 2013

Please see #281 - closing here.

@Ocramius Ocramius closed this Jun 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment