Allow root namespaces for Entities #299

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@haroldiedema

Allow root namespaces for entities to be "valid" since a prefix in symfony2 cannot be empty.

Allow root namespaces for Entities
Allow root namespaces for entities to be "valid" since a prefix in symfony2 cannot be empty.
@doctrinebot

This comment has been minimized.

Show comment Hide comment
@doctrinebot

doctrinebot Sep 19, 2013

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DCOM-218

We use Jira to track the state of pull requests and the versions they got
included in.

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DCOM-218

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Sep 19, 2013

Owner

\\ wouldn't work anyway, since get_class returns the class name without including the leading backslash

Owner

Ocramius commented Sep 19, 2013

\\ wouldn't work anyway, since get_class returns the class name without including the leading backslash

@haroldiedema

This comment has been minimized.

Show comment Hide comment
@haroldiedema

haroldiedema Sep 19, 2013

What part wouldn't work? I've tested this and it finds entities perfectly now.

There is no namespace in the entity classes, so it was either this "fix" or get rid of the validation (not-empty) check of the prefix option.

What part wouldn't work? I've tested this and it finds entities perfectly now.

There is no namespace in the entity classes, so it was either this "fix" or get rid of the validation (not-empty) check of the prefix option.

@haroldiedema

This comment has been minimized.

Show comment Hide comment
@haroldiedema

haroldiedema Sep 20, 2013

Descriminator maps don't seem to work properly anymore, so guess you're right. (Using latest 2.4.1 version)

Descriminator maps don't seem to work properly anymore, so guess you're right. (Using latest 2.4.1 version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment