DCOM-79 - Move lifecycle event args classes to Common #75

Merged
merged 5 commits into from Nov 21, 2011

Conversation

Projects
None yet
2 participants
Owner

beberlei commented Nov 19, 2011

No description provided.

+ public function __construct(ClassMetadata $classMetadata, ObjectManager $objectManager)
+ {
+ $this->classMetadata = $classMetadata;
+ $this->objectManager = $objectManager;
@stof

stof Nov 19, 2011

Member

extra spaces here

+ * Class that holds event arguments for a loadMetadata event.
+ *
+ * @author Jonathan H. Wage <jonwage@gmail.com>
+ * @since 2.0
@stof

stof Nov 19, 2011

Member

should be 2.2

+ * of entities.
+ *
+ * @link www.doctrine-project.org
+ * @since 2.0
@stof

stof Nov 19, 2011

Member

should be 2.2

+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.0
@stof

stof Nov 19, 2011

Member

same here

+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.0
@stof

stof Nov 19, 2011

Member

and here

+ * @since 2.0
+ * @author Daniel Freudenberger <df@rebuy.de>
+ */
+class PostFlushEventArgs extends EventArgs
@stof

stof Nov 19, 2011

Member

onFlush, preFlush and postFlush are exactly the same. Do we really need 3 classes ?

@stof

stof Nov 19, 2011

Member

and previous event classes could extend this class as they also have the getObjectManager method

+ */
+ public function getOldValue($field)
+ {
+ $this->assertValidField($field);
@stof

stof Nov 19, 2011

Member

wrong indentation here. There is probably a tab instead of spaces

+ */
+ private function assertValidField($field)
+ {
+ if ( ! isset($this->entityChangeSet[$field])) {
@stof

stof Nov 19, 2011

Member

indentation issue here too

beberlei added a commit that referenced this pull request Nov 21, 2011

Merge pull request #75 from doctrine/DCOM-79-Events
DCOM-79 - Move lifecycle event args classes to Common

@beberlei beberlei merged commit 98963b0 into master Nov 21, 2011

@stof stof deleted the DCOM-79-Events branch Dec 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment