New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped PHP 5.x and 7.0 support - minimum of PHP 7.1 requirement #785

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
3 participants
@Majkl578
Member

Majkl578 commented Apr 15, 2017

Supersedes and fixes #756.

Show outdated Hide outdated .travis.yml
@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 Apr 15, 2017

Member

Okay, HHVM will just not work in PHP 7 mode at all... It crashes Composer entirely in all versions (Symfony Finder specifically).
Suggestions?

Member

Majkl578 commented Apr 15, 2017

Okay, HHVM will just not work in PHP 7 mode at all... It crashes Composer entirely in all versions (Symfony Finder specifically).
Suggestions?

@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578
Member

Majkl578 commented Apr 15, 2017

@szymach

This comment has been minimized.

Show comment
Hide comment
@szymach

szymach Apr 16, 2017

Hey, I am curious whether support for HHVM is actually worth the effort? Perhaps add it as an allowed failure until the Facebook team resolves the issue?

szymach commented Apr 16, 2017

Hey, I am curious whether support for HHVM is actually worth the effort? Perhaps add it as an allowed failure until the Facebook team resolves the issue?

@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 Apr 16, 2017

Member

Maybe, but it's not up to me to decide.
HHVM support was always pain in the ass, i.e. Nette Framework dropped it because it was too broken/incompatible with PHP.

Member

Majkl578 commented Apr 16, 2017

Maybe, but it's not up to me to decide.
HHVM support was always pain in the ass, i.e. Nette Framework dropped it because it was too broken/incompatible with PHP.

@szymach

This comment has been minimized.

Show comment
Hide comment
@szymach

szymach Apr 16, 2017

Well, according Saldaek in the issue you have provided, there's less people using HHVM and Composer, than PHP 5.3 (~0.4%). If I may be so bold, I would suggest sidelining (if not dropping altogether) support for it, since it only slows down development progress without being actually used by any substantial number of people.

I know, it is not your call, but maybe someone else in the Doctrine team will consider this.

szymach commented Apr 16, 2017

Well, according Saldaek in the issue you have provided, there's less people using HHVM and Composer, than PHP 5.3 (~0.4%). If I may be so bold, I would suggest sidelining (if not dropping altogether) support for it, since it only slows down development progress without being actually used by any substantial number of people.

I know, it is not your call, but maybe someone else in the Doctrine team will consider this.

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Apr 16, 2017

Member

I think @szymach's observation makes it clear: supporting HHVM is not worth it, and won't be worth it any soon due to the amount of effort needed to do it, while a lot of its PHP5 compatibility issues remain unpatched (and aren't in the project's focus either, as it seems).

We can drop HHVM if we do an announcement, since we did indeed guarantee compatibility (see http://www.doctrine-project.org/2013/12/23/our-hhvm-roadmap.html )

Member

Ocramius commented Apr 16, 2017

I think @szymach's observation makes it clear: supporting HHVM is not worth it, and won't be worth it any soon due to the amount of effort needed to do it, while a lot of its PHP5 compatibility issues remain unpatched (and aren't in the project's focus either, as it seems).

We can drop HHVM if we do an announcement, since we did indeed guarantee compatibility (see http://www.doctrine-project.org/2013/12/23/our-hhvm-roadmap.html )

@lcobucci lcobucci referenced this pull request May 5, 2017

Closed

HHVM support #6424

@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 May 23, 2017

Member

@Ocramius @lcobucci Before I rebase this, are we going to support 7.0 or 7.1?

Member

Majkl578 commented May 23, 2017

@Ocramius @lcobucci Before I rebase this, are we going to support 7.0 or 7.1?

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius
Member

Ocramius commented May 23, 2017

@Majkl578 7.1

@Majkl578 Majkl578 changed the title from Drop PHP 5.x support to Drop PHP 5.x & 7.0 upport May 23, 2017

@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 May 23, 2017

Member

Roger, PR updated.

Member

Majkl578 commented May 23, 2017

Roger, PR updated.

@Ocramius Ocramius changed the title from Drop PHP 5.x & 7.0 upport to Drop PHP 5.x & 7.0 support May 23, 2017

@Ocramius Ocramius self-assigned this May 23, 2017

@Ocramius Ocramius added this to the 2.8.0 milestone May 23, 2017

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius May 23, 2017

Member

👍

Member

Ocramius commented May 23, 2017

👍

@Ocramius Ocramius merged commit 54d5eb6 into doctrine:master May 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Majkl578 Majkl578 deleted the Majkl578:php7-bump branch May 23, 2017

@jmikola jmikola referenced this pull request May 24, 2017

Merged

Bye bye HHVM. #24

@Ocramius Ocramius changed the title from Drop PHP 5.x & 7.0 support to Dropped PHP 5.x and 7.0 support - minimum of PHP 7.1 requirement Jul 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment