Skip to content
This repository

Add Proxy#__load() #81

merged 1 commit into from over 2 years ago

3 participants

Benjamin Eberlei Lukas Kahwe Smith Victor Berchet
Benjamin Eberlei

No description provided.

Lukas Kahwe Smith

whats the hold up with merging this? do you first want to prepare relevant PR's for the ORM/ODMs? if so i can help.

Benjamin Eberlei

No, sinc enobody implements this yet there is no problem :-

Benjamin Eberlei beberlei merged commit 583b0e1 into from
Lukas Kahwe Smith

actually PHPCR ODM already does .. but i will update it shortly :)

Lukas Kahwe Smith

i am still unsure if the interface is sufficient. atm we have if ($document instanceof Proxy && !$document->__isInitialized__) { in the ODM's and if ($entity instanceof Proxy && ! $entity->__isInitialized__) { in the ORM .. so imho we also need an isInitialized() method in the interface.

Lukas Kahwe Smith

we should also look at the needs of Doctrine\Common\Util\Debug

Victor Berchet

Is there any Doctrine CS for interface method visibility, there seems to be a mix in different files, public is not always specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Dec 03, 2011
Benjamin Eberlei beberlei Add Proxy#__load() 0ddb8dd
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 8 additions and 0 deletions. Show diff stats Hide diff stats

  1. +8 0 lib/Doctrine/Common/Persistence/Proxy.php
8 lib/Doctrine/Common/Persistence/Proxy.php
@@ -28,4 +28,12 @@
28 28 */
29 29 interface Proxy
30 30 {
  31 + /**
  32 + * Initialize this proxy if its not yet initialized.
  33 + *
  34 + * Acts as a no-op if already initialized.
  35 + *
  36 + * @return void
  37 + */
  38 + public function __load();
31 39 }

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.