Add Proxy#__load() #81

Merged
merged 1 commit into from Dec 6, 2011

Projects

None yet

3 participants

@beberlei
Member
beberlei commented Dec 3, 2011

No description provided.

@lsmith77
Member
lsmith77 commented Dec 6, 2011

whats the hold up with merging this? do you first want to prepare relevant PR's for the ORM/ODMs? if so i can help.

@beberlei
Member
beberlei commented Dec 6, 2011

No, sinc enobody implements this yet there is no problem :-

@beberlei beberlei merged commit 583b0e1 into master Dec 6, 2011
@lsmith77
Member
lsmith77 commented Dec 6, 2011

actually PHPCR ODM already does .. but i will update it shortly :)

@lsmith77
Member
lsmith77 commented Dec 6, 2011

i am still unsure if the interface is sufficient. atm we have if ($document instanceof Proxy && !$document->__isInitialized__) { in the ODM's and if ($entity instanceof Proxy && ! $entity->__isInitialized__) { in the ORM .. so imho we also need an isInitialized() method in the interface.

@lsmith77
Member
lsmith77 commented Dec 6, 2011

we should also look at the needs of Doctrine\Common\Util\Debug

@vicb

Is there any Doctrine CS for interface method visibility, there seems to be a mix in different files, public is not always specified

@stof stof deleted the ProxyLoadMethod branch Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment