New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Event Manager to doctrine/event-manager #842

Merged
merged 2 commits into from Jun 11, 2018

Conversation

Projects
None yet
4 participants
@Majkl578
Member

Majkl578 commented Jun 7, 2018

EventManager + EventSubscriber + EventArgs separated into doctrine/event-manager.

One step closer to finishing #826.

Note: @dev needs to be removed before 2.9.0 (once 1.0.0 is tagged).

@Majkl578 Majkl578 added the Improvement label Jun 7, 2018

@Majkl578 Majkl578 added this to the 2.9.0 milestone Jun 7, 2018

@Majkl578 Majkl578 requested review from Ocramius and lcobucci Jun 7, 2018

@Majkl578 Majkl578 force-pushed the Majkl578:separate-evm branch from 8dde5fb to e6e2b59 Jun 7, 2018

@alcaeus

I'd change the constraint - rest looks good 👍

@@ -19,7 +19,8 @@
"doctrine/cache": "1.*",
"doctrine/collections": "1.*",
"doctrine/lexer": "1.*",
"doctrine/annotations": "1.*"
"doctrine/annotations": "1.*",
"doctrine/event-manager": "1.*@dev"

This comment has been minimized.

@alcaeus

alcaeus Jun 7, 2018

Member

^1.0.0@dev (without @dev once we release it)?

This comment has been minimized.

@Majkl578

Majkl578 Jun 7, 2018

Member

I replaced all constraints with caret. 👍

This comment has been minimized.

@Majkl578

Majkl578 Jun 11, 2018

Member

bumped 👍

@Majkl578 Majkl578 force-pushed the Majkl578:separate-evm branch from e6e2b59 to b17d933 Jun 7, 2018

@Majkl578 Majkl578 force-pushed the Majkl578:separate-evm branch from b17d933 to a15200f Jun 11, 2018

@jwage

jwage approved these changes Jun 11, 2018

@Ocramius Ocramius self-assigned this Jun 11, 2018

@Ocramius Ocramius merged commit c0c61c0 into doctrine:master Jun 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ocramius

This comment has been minimized.

Member

Ocramius commented Jun 11, 2018

🚂

@Majkl578 Majkl578 deleted the Majkl578:separate-evm branch Jun 11, 2018

symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull request Jun 20, 2018

minor #27609 Remove direct dependencies on doctrine/common (Majkl578)
This PR was merged into the 4.2-dev branch.

Discussion
----------

Remove direct dependencies on doctrine/common

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | ?

Doctrine has recently separated multiple components from doctrine/common:
* [doctrine/event-manager](https://github.com/doctrine/event-manager) [[release notes](https://github.com/doctrine/event-manager/releases/tag/v1.0.0) | [split PR](doctrine/common#842)]
* [doctrine/persistence](https://github.com/doctrine/persistence) [[release notes](https://github.com/doctrine/persistence/releases/tag/v1.0.0) | [split PR](doctrine/common#845)]
* [doctrine/reflection](https://github.com/doctrine/reflection) [[release notes](https://github.com/doctrine/reflection/releases/tag/v1.0.0) | [split PR](doctrine/common#845)]

All of the packages are 100% backward compatible with their counterparts in Common 2.8.

This is a major step to slowly start with [phasing out doctrine/common package](doctrine/common#826) before ORM 3.0 / DBAL 3.0 / ODM 3.0.
Common 2.9.0 will also be composed from these new packages.

Most of the remaining parts in doctrine/common are likely to be deprecated (or already are), please see & discuss in [the PR over in doctrine/common repository](doctrine/common#845).

This PR therefore aims to remove the direct doctrine/common dependency from Symfony, replacing it by specific Doctrine components.

Commits
-------

b0fa398187 Remove direct dependencies on doctrine/common

fabpot added a commit to symfony/symfony that referenced this pull request Jun 20, 2018

minor #27609 Remove direct dependencies on doctrine/common (Majkl578)
This PR was merged into the 4.2-dev branch.

Discussion
----------

Remove direct dependencies on doctrine/common

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | ?

Doctrine has recently separated multiple components from doctrine/common:
* [doctrine/event-manager](https://github.com/doctrine/event-manager) [[release notes](https://github.com/doctrine/event-manager/releases/tag/v1.0.0) | [split PR](doctrine/common#842)]
* [doctrine/persistence](https://github.com/doctrine/persistence) [[release notes](https://github.com/doctrine/persistence/releases/tag/v1.0.0) | [split PR](doctrine/common#845)]
* [doctrine/reflection](https://github.com/doctrine/reflection) [[release notes](https://github.com/doctrine/reflection/releases/tag/v1.0.0) | [split PR](doctrine/common#845)]

All of the packages are 100% backward compatible with their counterparts in Common 2.8.

This is a major step to slowly start with [phasing out doctrine/common package](doctrine/common#826) before ORM 3.0 / DBAL 3.0 / ODM 3.0.
Common 2.9.0 will also be composed from these new packages.

Most of the remaining parts in doctrine/common are likely to be deprecated (or already are), please see & discuss in [the PR over in doctrine/common repository](doctrine/common#845).

This PR therefore aims to remove the direct doctrine/common dependency from Symfony, replacing it by specific Doctrine components.

Commits
-------

b0fa398 Remove direct dependencies on doctrine/common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment