Skip to content

[DCOM-86] Fix DCOM-86#90

Closed
FabioBatSilva wants to merge 1 commit into
doctrine:masterfrom
FabioBatSilva:DCOM-86
Closed

[DCOM-86] Fix DCOM-86#90
FabioBatSilva wants to merge 1 commit into
doctrine:masterfrom
FabioBatSilva:DCOM-86

Conversation

@FabioBatSilva

Copy link
Copy Markdown
Member

@schmittjoh

Copy link
Copy Markdown
Member

Hey Fabio,

we had this behavior at some point. However, this would prevent some annotations from working (including possibly PHPDoc annotations). See the following example:

use JMS\SerializerBundle\Annotation\Since;

class MyClass
{
    /** @since("1.1") */
    private $foo;
}

The above annotation is recognized at the moment, but with this patch it would be ignored. If I understand the ticket correctly, it seems like a performance optimization. So, I'd say we close it as won't fix.

@FabioBatSilva

Copy link
Copy Markdown
Member Author

Sorry @schmittjoh, I didn't know.
Can I close this one on jira ?

@schmittjoh

Copy link
Copy Markdown
Member

Yes, please.

@schmittjoh schmittjoh closed this Dec 30, 2011
@FabioBatSilva

Copy link
Copy Markdown
Member Author

I'm closing.

Thanks @schmittjoh .

@kdambekalns

Copy link
Copy Markdown

Too bad that performance optimization is that easily disregarded. Even if this pull request wasn't working, why is the full issue closed with it. Sigh.

@schmittjoh

Copy link
Copy Markdown
Member

We can re-open it if you think that it's still implementable. However, I don't really believe that - even if we would have applied the change above (which was not possible) - there would have been any significant speed-ups for your application.

@doctrinebot doctrinebot mentioned this pull request Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants