[DCOM-86] Fix DCOM-86#90
Conversation
|
Hey Fabio, we had this behavior at some point. However, this would prevent some annotations from working (including possibly PHPDoc annotations). See the following example: use JMS\SerializerBundle\Annotation\Since;
class MyClass
{
/** @since("1.1") */
private $foo;
}The above annotation is recognized at the moment, but with this patch it would be ignored. If I understand the ticket correctly, it seems like a performance optimization. So, I'd say we close it as won't fix. |
|
Sorry @schmittjoh, I didn't know. |
|
Yes, please. |
|
I'm closing. Thanks @schmittjoh . |
|
Too bad that performance optimization is that easily disregarded. Even if this pull request wasn't working, why is the full issue closed with it. Sigh. |
|
We can re-open it if you think that it's still implementable. However, I don't really believe that - even if we would have applied the change above (which was not possible) - there would have been any significant speed-ups for your application. |
Hello
This patch fix : http://www.doctrine-project.org/jira/browse/DCOM-86