Skip to content

[DCOM-86] Fix DCOM-86 #90

Closed
wants to merge 1 commit into from

3 participants

@FabioBatSilva
Doctrine member
@schmittjoh
Doctrine member

Hey Fabio,

we had this behavior at some point. However, this would prevent some annotations from working (including possibly PHPDoc annotations). See the following example:


use JMS\SerializerBundle\Annotation\Since;

class MyClass
{
    /** @since("1.1") */
    private $foo;
}

The above annotation is recognized at the moment, but with this patch it would be ignored. If I understand the ticket correctly, it seems like a performance optimization. So, I'd say we close it as won't fix.

@FabioBatSilva
Doctrine member

Sorry @schmittjoh, I didn't know.
Can I close this one on jira ?

@schmittjoh
Doctrine member

Yes, please.

@schmittjoh schmittjoh closed this Dec 30, 2011
@FabioBatSilva
Doctrine member

I'm closing.

Thanks @schmittjoh .

@kdambekalns

Too bad that performance optimization is that easily disregarded. Even if this pull request wasn't working, why is the full issue closed with it. Sigh.

@schmittjoh
Doctrine member

We can re-open it if you think that it's still implementable. However, I don't really believe that - even if we would have applied the change above (which was not possible) - there would have been any significant speed-ups for your application.

@doctrinebot doctrinebot referenced this pull request Dec 7, 2015
Closed

DCOM-86: k-fish #687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.