Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Make DesignDocument Parameter Optional #2

Merged
merged 1 commit into from over 1 year ago

2 participants

Bradley Holt Benjamin Eberlei
Bradley Holt

The DesignDocument parameter to CouchDBClient::createViewQuery should be optional, as it truly is optional. It is not needed, but the current interface forces me to provide it.

Benjamin Eberlei beberlei merged commit 49b22c8 into from
Benjamin Eberlei beberlei closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Apr 23, 2012
Bradley Holt Make DesignDocument parameter optional. 3a44148
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  lib/Doctrine/CouchDB/CouchDBClient.php
2  lib/Doctrine/CouchDB/CouchDBClient.php
@@ -365,7 +365,7 @@ public function deleteDocument($id, $rev)
365 365
      * @param DesignDocument $designDoc
366 366
      * @return View\Query
367 367
      */
368  
-    public function createViewQuery($designDocName, $viewName, DesignDocument $designDoc)
  368
+    public function createViewQuery($designDocName, $viewName, DesignDocument $designDoc = null)
369 369
     {
370 370
         return new View\Query($this->httpClient, $this->databaseName, $designDocName, $viewName, $designDoc);
371 371
     }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.