This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Updated URL-template for couchdb-lucene >= 1.0 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some days ago couchdb-lucene 1.0 was released and i think it brought some changes to the Proxy/Api URL structure as you can see in my small patch. The code above worked for my setup (CouchDB 1.5.0 & couchdb-lucene 1.0 & CouchDB-Client & CouchDB-ODM).
|
View need two lucene query classes and some way to pick the correct one based on configuration. Changing the existing one when people might still use the old version is not good. |
|
Hi Benjamin. Good solution - cause more failsafe then just update to match the new format. I assume that you can confirm the change of the format, correct? I wasn't that familiar with the couchdb + the client environment so that i just updated it lazy inline. Maybe i can implement a better solution. Let me check the code base again and i will let you know. |
beberlei
added a commit
that referenced
this pull request
Nov 11, 2015
Updated URL-template for couchdb-lucene >= 1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some days ago couchdb-lucene 1.0 was released and i think it brought some changes to the Proxy/Api URL structure as you can see in my small patch. The code above worked for my setup (CouchDB 1.5.0 & couchdb-lucene 1.0 & CouchDB-Client & CouchDB-ODM).