Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

refactor Load to easier override get_class-hash method #96

Open
pscheit opened this Issue Mar 20, 2013 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

pscheit commented Mar 20, 2013

hi there,

before i bootstrap everyhing an PR it:
for me the indexing with get_class in the loader does not work very well. I think you have a good reason to hash wich class-FQN, but i would love overload the loader, which is a little bit complicated

can I refactor the loader to use a new method hashFixture() in hasFixture and addFixture to make the loader easier extendable?

best regards

@pscheit pscheit added a commit to pscheit/data-fixtures that referenced this issue Mar 20, 2013

@pscheit pscheit fix #96
okay it was that easy..
ca9e4e0
Member

lavoiesl commented Mar 22, 2015

While I like the idea of having a hash function for this, perhaps even a NamedFixtureInterface that would behave like migrations, I fail to see a purpose for it, could you provide a use case?

@lavoiesl lavoiesl added the Refactor label Mar 22, 2015

@lavoiesl lavoiesl added this to the 2.0 milestone Mar 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment