Remove .gitmodules file and submodule dirs #6

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
8 participants
@ornicar
Contributor

ornicar commented Mar 14, 2011

This sounds absolutly obvious to me.

@ornicar

This comment has been minimized.

Show comment Hide comment
@ornicar

ornicar Mar 22, 2011

Contributor

Well should I argue about it?

Contributor

ornicar commented Mar 22, 2011

Well should I argue about it?

@ornicar

This comment has been minimized.

Show comment Hide comment
@ornicar

ornicar Mar 22, 2011

Contributor

Okay so Jon Wage said on IRC

 we just need to be able to clone the repo and run the tests easily without having to satisfy dependencies in order to help with development

OK. So I propose to rename .gitmodules to .gitmodules.dist. It is still easy to rename the file then update the submodules.

This is why I want this PR to be applied:

  • I use to manage my project dependencies with git submodule update --recursive
  • As a user of data-fixtures I don't need its common, dbal, orm and mongodb submodules. I have Doctrine already.
  • I don't want to download stuff I don't need (data-fixtures vendors = 126Mb)
  • I don't want duplicated instances of Doctrine in my project, it makes code browsing (ctags) and searching (find,grep,ack) painful.

Git is a great tool, let's not use it that way.
Does renaming .gitmodules to .gitmodules.dist sound acceptable for you?

Contributor

ornicar commented Mar 22, 2011

Okay so Jon Wage said on IRC

 we just need to be able to clone the repo and run the tests easily without having to satisfy dependencies in order to help with development

OK. So I propose to rename .gitmodules to .gitmodules.dist. It is still easy to rename the file then update the submodules.

This is why I want this PR to be applied:

  • I use to manage my project dependencies with git submodule update --recursive
  • As a user of data-fixtures I don't need its common, dbal, orm and mongodb submodules. I have Doctrine already.
  • I don't want to download stuff I don't need (data-fixtures vendors = 126Mb)
  • I don't want duplicated instances of Doctrine in my project, it makes code browsing (ctags) and searching (find,grep,ack) painful.

Git is a great tool, let's not use it that way.
Does renaming .gitmodules to .gitmodules.dist sound acceptable for you?

@jwage

This comment has been minimized.

Show comment Hide comment
@jwage

jwage Mar 22, 2011

Member

Lets pull in Benjamin to see what he thinks about the change. I am okay with changing it but we should do it across all libraries.

Member

jwage commented Mar 22, 2011

Lets pull in Benjamin to see what he thinks about the change. I am okay with changing it but we should do it across all libraries.

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Mar 22, 2011

Member

Yeah I stumbled over this with the other Doctrine projects too. Not sure what the best solution is though.

Member

lsmith77 commented Mar 22, 2011

Yeah I stumbled over this with the other Doctrine projects too. Not sure what the best solution is though.

@beberlei

This comment has been minimized.

Show comment Hide comment
@beberlei

beberlei Jun 11, 2011

Member

I think we can provide a shell script that loads all dependencies in tests/ or not?

Member

beberlei commented Jun 11, 2011

I think we can provide a shell script that loads all dependencies in tests/ or not?

@l3pp4rd

This comment has been minimized.

Show comment Hide comment
@l3pp4rd

l3pp4rd Jun 11, 2011

Contributor

yes, it would be better to have some scripts instead, like symfony-standard vendors.sh. I have tried renaming .gitmodules it fails upon --recursive action you would need to remove those module entries from .git/config

Contributor

l3pp4rd commented Jun 11, 2011

yes, it would be better to have some scripts instead, like symfony-standard vendors.sh. I have tried renaming .gitmodules it fails upon --recursive action you would need to remove those module entries from .git/config

@stof

This comment has been minimized.

Show comment Hide comment
@stof

stof Jun 11, 2011

Member

Symfony provides a vendors.php script used to load the dependencies of the testsuite. The same could be done for Doctrine: https://github.com/symfony/symfony/blob/master/vendors.php

Member

stof commented Jun 11, 2011

Symfony provides a vendors.php script used to load the dependencies of the testsuite. The same could be done for Doctrine: https://github.com/symfony/symfony/blob/master/vendors.php

@oloflarsson

This comment has been minimized.

Show comment Hide comment
@oloflarsson

oloflarsson Nov 16, 2011

This issue is not fixed yet is it?

I would like to use migrations together with doctrine2 orm.

The .gitmodules files looks the same for both those projects. Meaning that if I would use git clone --recursive I would download doctrine-common, doctrine-dbal, Symfony/Component/Console and /Symfony/Component/Yaml TWICE.

If you can't find a good solution I would be very glad if you could create some new documentation on how to use the projects together.

Does this gist contain a semi-solution??
https://gist.github.com/857150

Edit: No. Since they use git submodule update --init --recursive at the end they would download loads of duplicate files as well... wouldn't they?

This issue is not fixed yet is it?

I would like to use migrations together with doctrine2 orm.

The .gitmodules files looks the same for both those projects. Meaning that if I would use git clone --recursive I would download doctrine-common, doctrine-dbal, Symfony/Component/Console and /Symfony/Component/Yaml TWICE.

If you can't find a good solution I would be very glad if you could create some new documentation on how to use the projects together.

Does this gist contain a semi-solution??
https://gist.github.com/857150

Edit: No. Since they use git submodule update --init --recursive at the end they would download loads of duplicate files as well... wouldn't they?

@oloflarsson

This comment has been minimized.

Show comment Hide comment
@oloflarsson

oloflarsson Nov 16, 2011

My solution is for now to NOT use --recursive.

I use this instead: https://github.com/oloflarsson/cby/blob/135eb56a856b9a739d1db9b92f530cfb5eb7b3ec/getlibs.php

My solution is for now to NOT use --recursive.

I use this instead: https://github.com/oloflarsson/cby/blob/135eb56a856b9a739d1db9b92f530cfb5eb7b3ec/getlibs.php

@nfx

This comment has been minimized.

Show comment Hide comment
@nfx

nfx Jul 18, 2012

So, it is now useful to use composer instead of git submodules. shall you maybe merge this into master?

nfx commented Jul 18, 2012

So, it is now useful to use composer instead of git submodules. shall you maybe merge this into master?

@jwage

This comment has been minimized.

Show comment Hide comment
@jwage

jwage Sep 18, 2012

Member

Yes, I think we can merge it if we can get it updated.

Member

jwage commented Sep 18, 2012

Yes, I think we can merge it if we can get it updated.

@ornicar

This comment has been minimized.

Show comment Hide comment
@ornicar

ornicar Jan 29, 2013

Contributor

nevermind

Contributor

ornicar commented Jan 29, 2013

nevermind

@ornicar ornicar closed this Jan 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment