Skip to content

Loading…

DBAL-183: Adding "Unknown Type" to stage deprecated custom type removal #1353

Closed
doctrinebot opened this Issue · 6 comments

2 participants

@doctrinebot

Jira issue originally created by user gedrox:

Today have experienced problem with schema update when a custom type was removed completely from the code.

Problem was that inside the database column comment the type name was created. Still the type class couldn't be found in the code anymore. So unknownColumnType exception was raised without possibility to update or even drop the schema from doctrine command line calls.

The idea to fix this globally in DBAL would be to create UnknownType (Doctrine\DBAL\Types\Type instance) which would be returned every time unknown type is requested.

The new type should throw unknownColumnType exception each time any of it's methods is called.

Currently I have made workaround for this issue by binding the missing types to UnknownType class created inside my project so the upgrade runs smoothly for other developers as well.

@doctrinebot

Comment created by gedrox:

Closing for issue DBAL-232 which also fixes the problem.

@doctrinebot

Issue was closed with resolution "Duplicate"

@doctrinebot

Comment created by @beberlei:

A related Github Pull-Request [GH-129] was opened
#129

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-406] was closed:
#406

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-129] was closed:
doctrine/common#129

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-129] was closed:
#129

@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.