Skip to content

Loading…

DBAL-302: [GH-168] DebugStack should ignore stopQuery when disabled #1485

Closed
doctrinebot opened this Issue · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of dpb587:

Url: #168

Message:

I noticed that DebugStack was adding an empty element when it was disabled. This PR changes it to match startQuery with its behavior.

1) Doctrine\Tests\DBAL\Logging\DebugStackTest::testLoggedQueryDisabled
Failed asserting that two arrays are equal.
--- Expected
<ins></ins><ins> Actual
@@ @@
 Array
 (
</ins>    [0] => Array
<ins>        (
</ins>            [executionMS] => 1341871660.9651
<ins>        )
</ins>
 )

I've submitted the PR to 2.0.x since that's where the bug is first seen and is still listed as stable on doctrine-project.org. Preferably this could also be applied to newer branches as well, or I can also submit separate PRs.

@doctrinebot

Comment created by @beberlei:

A related Github Pull-Request [GH-168] was closed
#168

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label
@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot added this to the 2.3 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.