DBAL-315: [GH-182] Added a missing method in the Constraint interface #1499

Closed
doctrinebot opened this Issue Aug 6, 2012 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of stof:

Url: #182

Message:

This adds a missing method in the Constraint interface. The method is already defined in AbstractAsset which is extended by both classes implementing the interface. the AbstractPlatform is calling this method on objects after checking they are implementing the interface. So either the method should be part of the interface, or all places using the interface as typehint should be refactored to check for the classes (examples can be found here and there).

Adding a method in an interface is technically a BC break but this method is not really a public extension point. what do you think @beberlei ?

@doctrinebot

Comment created by @beberlei:

A related Github Pull-Request [GH-182] was closed
#182

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label Dec 6, 2015
@asm89 asm89 was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.3 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment