DBAL-450: [GH-275] accept array as parameter in getConcatExpression #1648

Closed
doctrinebot opened this Issue Feb 19, 2013 · 1 comment

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of broncha:

Url: #275

Message:

The function getConcatExpression accepts strings, but as there can be any number of parameters passed to this and while calling from ConcatFunction sqlwalker has to walk all the parameters. So it would be better if getConcatExpression accepts array. Infact even better if it only accepts array. It would be much cleaner. Also I am opening a pull request in ORM for ConcatFunction as it only validates 2 primaryStrings. It should support more than two. SO for that to happen, getConcatExpression should accept array as parameter.

@doctrinebot

Issue was closed with resolution "Invalid"

@doctrinebot doctrinebot added the Bug label Dec 6, 2015
@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment