DBAL-470: [GH-291] Optimize abstract platform #1670

Closed
doctrinebot opened this Issue Mar 24, 2013 · 5 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: #291

Message:

This PR optimizes the AbstractPlatform class in the following ways:

  • Add dedicated use statemtent for each class import
  • Add missing class imports
  • Add missing phpDoc blocks for methods
  • Fix existing phpDocs (parameters, return types, @throws tags, FQDN types, indentation etc.)
  • "Normalize" phpDocs (consistent verbs for what a method does, reuse of certain phrases for similar method types etc.)
  • Fix CS
  • Improve certain code portions

I hope this is a welcomed improvement. It reads much better now and feels somewhat cleaner to me.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-291] was closed:
doctrine/common#291

@doctrinebot

Comment created by @FabioBatSilva:

Closed ... See : doctrine/common#291 for more details..

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by @deeky666:

@Fabio: Are you sure your comment is related to this issue? Looks like the PR you referenced is from Common repository but this ticket is related to DBAL...

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-291] was closed:
#291

@doctrinebot doctrinebot added the Bug label Dec 6, 2015
@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment