DBAL-490: [GH-303] Fixed a PHP warning in DBALException::driverExceptionDuringQuery() #1692

Closed
doctrinebot opened this Issue Apr 9, 2013 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: #303

Message:

When a query parameter contains binary data, driverExceptionDuringQuery() generates a PHP warning. This is because it internally uses json_encode(), which expects valid UTF-8 strings (at least in PHP 5.4.13).

This PR removes the warning with the @ operator. json_encode() will still return a string representation, replacing the binary data with null.

I added a test that fails before the fix.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-303] was closed:
#303

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label Dec 6, 2015
@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.3.4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment