Skip to content

Loading…

DBAL-498: [GH-306] [DBAL-497] Fixed SQL Server platform replacing 'FROM' in column names during limit #1700

Closed
doctrinebot opened this Issue · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of shaneneuerburg:

Url: #306

Message:

The regex used to replace the FROM clause was in a "starts with" form, which also matched column names that start with the word "FROM". This resulted in column names being replaced with the logic used for limiting, breaking the query once pagination is used. I added a whitespace requirement after "FROM' in the regex as well as a trailing whitespace in the replacement.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-306] was closed:
#306

@doctrinebot

Comment created by @ocramius:

merged

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-306] was closed:
doctrine/common#306

@doctrinebot doctrinebot added the Bug label
@doctrinebot doctrinebot added this to the 2.4 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.