Skip to content

Loading…

DBAL-566: Schema Comparator does not identify renamed indexes #1776

Closed
doctrinebot opened this Issue · 7 comments

2 participants

@doctrinebot

Jira issue originally created by user ben.davies:

The schema comparator does not identify renaming of used declared indexes.

This is partly due to the renamed index always fulfilling itself
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/Comparator.php#L440

it looks like the logic for columns should be repeated, where renames are detected.

@doctrinebot

Comment created by @deeky666:

May I ask what advantages you get when the comparator detects renamed indexes? An ALTER TABLE statement would still have to drop and recreate the index, doesn't it?

@doctrinebot

Comment created by @deeky666:

Patch supplied in PR: #473

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-473] was closed:
#473

@doctrinebot

Comment created by @deeky666:

Fixed in commit: 6d0e8e2

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by ben.davies:

Awesome Steve!

@doctrinebot doctrinebot added the Bug label
@deeky666 deeky666 was assigned by doctrinebot
@doctrinebot doctrinebot added this to the 2.5 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.