DBAL-590: Doctrine\DBAL\Schema\Column::visit Calls a Method That Doesn't Exist on Doctrine\DBAL\Scema\Visitor\Visitor #1802

Closed
doctrinebot opened this Issue Aug 27, 2013 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user chrisguitarguy:

Column::visit tries to Doctrine\DBAL\Schema\Visitor\Visitor::accept

https://github.com/doctrine/dbal/blob/2.3/lib/Doctrine/DBAL/Schema/Visitor/Visitor.php#L42
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/Column.php#L471

It doesn't look like Visitor actually has an accept method.
https://github.com/doctrine/dbal/blob/2.3/lib/Doctrine/DBAL/Schema/Visitor/Visitor.php
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/Visitor/Visitor.php

The method needed seems to be Visitor:: acceptColumn, but Column itself doesn't seem to be aware of it's parent table in any way.

@doctrinebot

Comment created by @beberlei:

Removed the method, the Table#visit() method is responsible for this.

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label Dec 7, 2015
@beberlei beberlei was assigned by doctrinebot Dec 7, 2015
@doctrinebot doctrinebot added this to the 2.5 milestone Dec 7, 2015
@doctrinebot doctrinebot closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment