Skip to content

Loading…

DBAL-692: [GH-436] phpdoc in Table::addForeignKey() update #1914

Closed
doctrinebot opened this Issue · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of velosipedist:

Url: #436

Message:

Added significant typehint in PhpDoc: $foreignTable param in addForeignKeyConstraint() can be just string name of table.

It unobvious in IDE hinting and treated as wrong param. It even can confuse developer, forcing him use foreign keys additions only using existing tables. That was my case, for example :confused: Lost time till found out, that Table schema not necessary to exist for Foreign Key referring .

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-436] was closed:
#436

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label
@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot added this to the 2.5 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.