DBAL-721: [GH-457] Fix composite primary key introspection on Sqlite #1946

Closed
doctrinebot opened this Issue Dec 22, 2013 · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: #457

Message:

Running the Sqlite testsuite I get the following error:

There was 1 failure:

1) Doctrine\Tests\DBAL\Functional\Schema\SqliteSchemaManagerTest::testListTableIndexes
Failed asserting that two arrays are equal.
--- Expected
<ins></ins>+ Actual
@@ @@
 Array (
     0 => 'id'
-    1 => 'other_id'
 )

/home/deeky/dev/doctrine/dbal/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php:272

This is due to the schema manager not correctly building composite primary keys on Sqlite. I don't know why this does not fail on Travis but accoding to the official documentation this approach is the correct implementation.
I did not add a dedicated test for this as there obviously already is one that covers this.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-457] was closed:
#457

@doctrinebot

Comment created by @deeky666:

Fixed in commit: 0724b02

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label Dec 7, 2015
@beberlei beberlei was assigned by doctrinebot Dec 7, 2015
@doctrinebot doctrinebot added this to the 2.5 milestone Dec 7, 2015
@doctrinebot doctrinebot closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment