DBAL-794: [GH-517] Fix method signature in Doctrine\DBAL\Driver\Connection #2025

Closed
doctrinebot opened this Issue Jan 19, 2014 · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of raziel057:

Url: #517

Message:

The method prepare must have an optional driverOptions parameter to be compatible with class which implement the interface Doctrine\DBAL\Driver\Connection.

To avoid this problem:

HipHop Fatal error: Declaration of Doctrine\DBAL\Driver\PDOConnection::prepare() must be compatible with that of Doctrine\DBAL\Driver\Connection::prepare() in /home/travis/build/symfony/symfony/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 30

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-517] was closed:
#517

@doctrinebot

Comment created by @ocramius:

The API was actually fixed by the HHVM folks, so we don't need the PR anymore.

@doctrinebot

Issue was closed with resolution "Won't Fix"

@doctrinebot doctrinebot added the Bug label Dec 7, 2015
@Ocramius Ocramius was assigned by doctrinebot Dec 7, 2015
@doctrinebot doctrinebot added this to the 2.5 milestone Dec 7, 2015
@doctrinebot doctrinebot closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment