DBAL-862: [GH-563] Lower case "order by" keyword causes wrong LIMIT query on SQL Server #2101

Closed
doctrinebot opened this Issue Apr 2, 2014 · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of stchr:

Url: #563

Message:

SQLServerPlatform::modifyLimitQuery('SELECT * FROM user order by username') (lowercase order by)
returns
SELECT ** FROM (SELECT **, ROW*NUMBER() OVER (ORDER BY order) AS doctrine_rownum FROM user order by username) AS doctrine_tbl WHERE doctrine*rownum BETWEEN 1 AND 10
instead of
SELECT ** FROM (SELECT **, ROW*NUMBER() OVER (ORDER BY username) AS doctrine_rownum FROM user) AS doctrine_tbl WHERE doctrine*rownum BETWEEN 1 AND 10

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-563] was closed:
#563

@doctrinebot

Comment created by @deeky666:

Fixed in commit: d6b9140

@doctrinebot

Issue was closed with resolution "Fixed"

@deeky666 deeky666 was assigned by doctrinebot Dec 7, 2015
@doctrinebot doctrinebot added this to the 2.5 milestone Dec 7, 2015
@doctrinebot doctrinebot closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment