Skip to content

Loading…

DBAL-968: SQL Server modifyLimitQuery broken #2214

Closed
doctrinebot opened this Issue · 4 comments

4 participants

@doctrinebot

Jira issue originally created by user @zeroedin-bill:

The recent change to SQLServerPlatform.php @jaylinski:improved sqlserver 'doModifyLimitQuery' select-from pattern broke the ORM Paginator's queries on SQL server.

I investigated, and found that some of the test cases for the SQL Server platform weren't actually correct SQL. Also, there were no test cases that covered what the paginator is doing, so I've written test cases for those. I will open a pull request for this issue.

The modifyLimitQuery method in SQLServerPlatform.php should be fixed to pass the fixed old tests and the new tests.

My concern is that that method is becoming too complex, but that's an issue for another day.

@doctrinebot

Comment created by @ocramius:

I'm gonna cry. Thank you, MSSQL, you make our lives so much "easier" :-(

@doctrinebot doctrinebot added the Bug label
@beberlei beberlei was assigned by doctrinebot
@beberlei beberlei was unassigned by deeky666
@deeky666
Doctrine member

@zeroedin-bill maybe this is also fixed already?

@zeroedin-bill
Doctrine member

Yup, this is the original thing that sent me down the rabbit hole.

@zeroedin-bill zeroedin-bill added this to the 2.5.3 milestone
@deeky666
Doctrine member

Weeeh :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.