Additions to Platform

[aboks]

Feature Request

Q	A
New Feature	yes
RFC	no
BC Break	no

Summary

Hi DBAL team, we're currently in the process of migrating our own database abstraction (MySQL/MariaDB and SQLite only) to Doctrine DBAL. While doing so, we noticed that we have some abstraction for functionality that differs between MySQL and SQLite, for which there is no method yet on the DBAL platform classes. We're wondering if you would accept PR's for these cases. They would be things like:

• Syntax to use for INSERT IGNORE INTO (SQLite requires INSERT OR IGNORE INTO)
• Syntax to use for GROUP_CONCAT (MySQL uses GROUP_CONCAT(%s SEPARATOR %s), SQLite uses GROUP_CONCAT(%s, %s)) -> see Add getAggregateConcatExpression to platform #4041
• Syntax to use for ANALYZE TABLE (SQLite uses just ANALYZE)
• Whether the database supports SELECT ... FOR UPDATE
• Whether the database supports SELECT ... LOCK IN SHARE MODE
• Whether the database supports UPDATE ... ORDER BY
• Whether the database supports multi-row inserts
• Syntax to use for LEAST/GREATEST (SQLite uses MIN/MAX)
• Whether the database supports CONCAT_WS
• Whether the database supports CREATE TABLE LIKE
• Whether the database supports INSERT ... ON DUPLICATE KEY UPDATE
• Whether the database supports UPDATE ... JOIN ...

If you'd welcome those, I will create separate issues/PR's for each of them. In general, against which branch would you like such PR's? Any guidelines or specific things to keep in mind when adding functionality to the platform layer?

[morozov]

Closing as non-actionable.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.