Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of KeywordList constructor is not enforced #4510

Closed
morozov opened this issue Feb 26, 2021 · 1 comment · Fixed by #4587, #4547, #4583 or #4597
Closed

Signature of KeywordList constructor is not enforced #4510

morozov opened this issue Feb 26, 2021 · 1 comment · Fixed by #4587, #4547, #4583 or #4597

Comments

@morozov
Copy link
Member

morozov commented Feb 26, 2021

Psalm on level 2:

ERROR: UnsafeInstantiation - lib/Doctrine/DBAL/Tools/Console/Command/ReservedWordsCommand.php:192:27 - Cannot safely instantiate class Doctrine\DBAL\Platforms\Keywords\KeywordList with "new $class_name" as its constructor might change in child classes (see https://psalm.dev/229)
            $keywords[] = new $class();
@morozov morozov changed the title Signature of KeywordList lists is not enforced Signature of KeywordList constructor is not enforced Feb 26, 2021
morozov added a commit to morozov/dbal that referenced this issue Apr 1, 2021
@morozov morozov added this to the 4.0.0 milestone Apr 2, 2021
morozov added a commit that referenced this issue Apr 4, 2021
[GH-4510] Remove AbstractPlatform::getReservedKeywordsClass()
morozov added a commit that referenced this issue Apr 5, 2021
[GH-4510] Deprecate ReservedWordsCommand::setKeywordListClass()
morozov added a commit that referenced this issue Apr 10, 2021
[GH-4510] Remove ReservedWordsCommand::setKeywordListClass()
@github-actions
Copy link

github-actions bot commented Jul 27, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.