Connection quote() ignores returned value from getBindingInfo()#124
Merged
Conversation
guilhermeblanco
added a commit
that referenced
this pull request
Mar 29, 2012
Connection quote() ignores returned value from getBindingInfo()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing something here, but this simple change seems to be necessary to allow for proper type management in quote(). For example, without this change passing a DateTime object as $input with $type = 'date' will resolve the proper string value in getBindingInfo, but then still attempt to pass the DateTime to PDO, which of course doesn't work.