Add typehint info to core types for use by entity generator. #135

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@benlumley

So as you probably know, the EntityGenerator doesn't typehint the setters for the DateTime types (datetime, date, datetimetz, time) - which has just caused me to miss an obvious error, and judging from google, plenty of others before me too.

So I've added it - you'll have a pull request in a sec on the doctrine2 repo for that, but it needs this change too - which provides the mapping info.

Added typehints map to Type class, plus a getter - used to provide ty…
…pehint info to support feature added to entitygenerator
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Apr 19, 2012

Member

I don't see the need to store this array in DBAL, especially as custom types cannot expand the array. You should put it directly in the EntityGenerator

Member

stof commented Apr 19, 2012

I don't see the need to store this array in DBAL, especially as custom types cannot expand the array. You should put it directly in the EntityGenerator

@benlumley

This comment has been minimized.

Show comment
Hide comment
@benlumley

benlumley Apr 19, 2012

OK - reject this one and I'll adjust the other PR.

Ben

On Thursday, 19 April 2012 at 09:16, Christophe Coevoet wrote:

I don't see the need to store this array in DBAL, especially as custom types cannot expand the array. You should put it directly in the EntityGenerator


Reply to this email directly or view it on GitHub:
#135 (comment)

OK - reject this one and I'll adjust the other PR.

Ben

On Thursday, 19 April 2012 at 09:16, Christophe Coevoet wrote:

I don't see the need to store this array in DBAL, especially as custom types cannot expand the array. You should put it directly in the EntityGenerator


Reply to this email directly or view it on GitHub:
#135 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment