Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Added missing regex delimiters in the testsuite #150

Merged
merged 1 commit into from almost 2 years ago

3 participants

Christophe Coevoet Don't Add Me To Your Organization a.k.a The Travis Bot Benjamin Eberlei
Christophe Coevoet
stof commented May 18, 2012

The AbstractSchemaManager expects getting the regex with its
delimiters since 8beb732 but the tests were not updated.

Christophe Coevoet Added missing regex delimiters in the testsuite
The AbstractSchemaManager expects getting the regex with its
delimiters since 8beb732 but the tests were not updated.
9409886
Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 9409886 into 8fe368e).

Benjamin Eberlei beberlei merged commit 0b9cf40 into from May 20, 2012
Benjamin Eberlei beberlei closed this May 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 18, 2012
Christophe Coevoet Added missing regex delimiters in the testsuite
The AbstractSchemaManager expects getting the regex with its
delimiters since 8beb732 but the tests were not updated.
9409886
This page is out of date. Refresh to see the latest.
4  tests/Doctrine/Tests/DBAL/Functional/Schema/PostgreSqlSchemaManagerTest.php
@@ -202,11 +202,11 @@ public function testFilterSchemaExpression()
202 202
         $column = $testTable->addColumn('id', 'integer');
203 203
         $this->_sm->createTable($testTable);
204 204
 
205  
-        $this->_conn->getConfiguration()->setFilterSchemaAssetsExpression('^dbal204_');
  205
+        $this->_conn->getConfiguration()->setFilterSchemaAssetsExpression('#^dbal204_#');
206 206
         $names = $this->_sm->listTableNames();
207 207
         $this->assertEquals(2, count($names));
208 208
 
209  
-        $this->_conn->getConfiguration()->setFilterSchemaAssetsExpression('^dbal204_test');
  209
+        $this->_conn->getConfiguration()->setFilterSchemaAssetsExpression('#^dbal204_test#');
210 210
         $names = $this->_sm->listTableNames();
211 211
         $this->assertEquals(1, count($names));
212 212
     }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.