Fixed a typo in a method name #181

Merged
merged 1 commit into from Aug 6, 2012

Conversation

Projects
None yet
5 participants
Member

stof commented Aug 6, 2012

This renaming is technically a BC break, but as the method is new in 2.3, I think we could still fix the typo without providing a BC layer for it (the ORM does not call the method btw).
@beberlei If you think that we should already provide the BC layer for the method, tell me and I will add it. However, we should then decide if we want the BC for code calling the platform or for custom platforms implementing the method (we cannot provide both).

This pull request passes (merged 3f5fda9 into 4319165).

guilhermeblanco added a commit that referenced this pull request Aug 6, 2012

Merge pull request #181 from stof/fix_method_name
Fixed a typo in a method name

@guilhermeblanco guilhermeblanco merged commit 807e229 into doctrine:master Aug 6, 2012

Contributor

fprochazka commented Aug 7, 2012

Why didn't you created method like this?

public function getGuidTypeDeclartionSQL(array $field)
{
    trigger_error("Method is deprecated, use ... instead ", E_USER_NOTICE);
    return $this->getGuidTypeDeclarationSQL($field);
}

It could be there few more versions before removing.

Member

stof commented Aug 7, 2012

@hosiplan the method is not part of any stable release. It is a new feature of Doctrine 2.3, which is not stable yet. See the description of the PR.

Contributor

fprochazka commented Aug 7, 2012

Well, I've overlooked that, sorry :)

marijn commented on 3f5fda9 Sep 4, 2012

@beberlei can you merge this commit into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment